Use socket.IPPROTO_TCP for Jython

[jfreeland]

Minor change to manually specify SOL_TCP = protocol version 6 when starting serving. This attribute does not exist in Jython and requires manual specification.

#1373
pika/pika#67

[jfreeland]

There must be a better way to do what I'm doing. Will revisit soon, have to make progress on other fronts for a bit.

[jandemter]

The proper way to solve this is to just use socket.IPPROTO_TCP instead of SOL_TCP. Can you please change your pull request to use that?

[jfreeland]

Sorry for the delay. Will test with IPPROTO_TCP and resubmit next week (holiday).

[davidism]

I installed jython, socket.SOL_TCP and socket.IPPROTO_TCP both exist. Tried with OpenJDK 7 and 11, and Oracle JDK 7.

$ /opt/jython/bin/jython 
Jython 2.7.1 (default:0df7adb1b397, Jun 30 2017, 19:02:43) 
[OpenJDK 64-Bit Server VM (Oracle Corporation)] on java11.0.1
Type "help", "copyright", "credits" or "license" for more information.
>>> import socket
>>> socket.IPPROTO_TCP
6
>>> socket.SOL_TCP
6

[jandemter]

Does indeed work out of the box with jython 2.7.1, thanks! jython.org offers 2.7.0 as the latest version, that's why I and most likely @jfreeland as well ended up using that.

[davidism]

Yeah, I noticed that Arch installed 2.7.1, but their site only lists 2.7.0. I'm OK with changing it to IPPROTO_TCP then.

[jfreeland]

Thanks for the feedback. I was using Ubuntu 16.04 and out of the box apt installed jython 2.5.3 which prompted this. Notice in the second commit I had issues with socket.AF_UNIX as well. I'm relatively confident that my commits were not the proper way to handle this. I'm happy to revert or try to learn how to do it the right way, just let me know.

…

On Wed, Nov 21, 2018 at 1:04 PM David Lord ***@***.***> wrote: Yeah, I noticed that Arch installed 2.7.1, but their site only lists 2.7.0. I'm OK with changing it to IPPROTO_TCP then. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1375 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdgU6KSD6NpvF4gDc1Pko3qf7OG4ACGsks5uxaPOgaJpZM4XaBUP> .

-- Joey Freeland +13124518906

[davidism]

We already merged a fix for AF_UNIX. I verified that IPPROTO_TCP exists in Jython 2.5.3. Pushed a new patch to the PR with just that change.