Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/clearer key errors #1395

Merged
merged 2 commits into from Nov 18, 2018

Conversation

Projects
None yet
2 participants
@dgmouris
Copy link
Contributor

commented Nov 12, 2018

Closes #1128

Adds the key error to the HTTP exception description.

@davidism

This comment was marked as resolved.

Copy link
Member

commented Nov 13, 2018

dgmouris and others added some commits Nov 12, 2018

move get_description into wrap class
treat BadRequestKeyError arg like KeyError arg

@davidism davidism force-pushed the dgmouris:improvement/clearer-key-errors branch from 18a4203 to da9d70a Nov 18, 2018

@davidism

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

After reviewing your changes, I realized we can move them back into HTTPException.wrap in a general way. So any wrapped exception can benefit from the added description. Thanks for working on this!

@davidism davidism added this to the 0.15 milestone Nov 18, 2018

@davidism davidism merged commit c6fdc7c into pallets:master Nov 18, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

davidism added a commit that referenced this pull request Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.