Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/clearer key errors #1395

Merged
merged 2 commits into from Nov 18, 2018

Conversation

@dgmouris
Copy link
Contributor

@dgmouris dgmouris commented Nov 12, 2018

Closes #1128

Adds the key error to the HTTP exception description.

@davidism

This comment has been hidden.

@davidism davidism force-pushed the improvement/clearer-key-errors branch from 18a4203 to da9d70a Nov 18, 2018
@davidism
Copy link
Member

@davidism davidism commented Nov 18, 2018

After reviewing your changes, I realized we can move them back into HTTPException.wrap in a general way. So any wrapped exception can benefit from the added description. Thanks for working on this!

@davidism davidism added this to the 0.15 milestone Nov 18, 2018
@davidism davidism merged commit c6fdc7c into pallets:master Nov 18, 2018
1 of 2 checks passed
davidism added a commit that referenced this issue Nov 18, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants