Improve DebuggedApplication.get_resource so that it can return resource in zipped library.#1401
Merged
davidism merged 1 commit intoNov 22, 2018
Conversation
Member
|
Thanks! I think this could be simplified by using |
Contributor
Author
|
Thank you for the reply. |
Member
|
A few unused imports: https://travis-ci.org/pallets/werkzeug/jobs/458441287#L487-L489 |
Contributor
Author
|
I'm so sorry for the inconvenience... |
DebuggedApplication.get_resource uses pkgutil.get_data Use pkgutil to simplify get_resource.
davidism
force-pushed
the
improvement_for_zip_support
branch
from
7fbe5bb to
34ed01b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is not zip-safe because
DebuggedApplication.get_resourcecannot return binary data inshareddirectory.This changeset improves
DebuggedApplication.get_resourceso that it can return binary data inshareddirectory even if werkzeug is included in pythonXX.zip.I know that
setup.pysetszip_safeto false, but I believe that this changeset improves this library.If you don't like this patch, please ignore it.
Regards,
Murase