rewrite test client redirect handling#1402
Merged
Merged
Conversation
This was referenced Nov 25, 2018
3c24062 to
965bbc0
Compare
* EnvironBuilder can be initialized from an environ. * Redirect environ is initialized from initial environ. * Script root and path are correctly distinguished. * HEAD method is not changed to GET. * Headers are passed to new request for all codes. * Body and relevant headers are dropped except for 307 and 308. * EnvironBuilder sets content type and length headers from autodetection * Better error message when disallowing domain redirects. * Test client recognizes 308 code. * Add 308 to http codes.
965bbc0 to
d27ac6c
Compare
Member
Author
|
Another change in #1403, intermediate redirect response bodies are exhausted even when |
This was referenced Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnvironBuilder.from_environcreates a builder from an existing environ. The previous code was passingEnvironBuilder(environ), but that doesn't mean anything to__init__.open, rather than passing only some args toopen.