Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfc2231 parameter continuation #1417

merged 2 commits into from Dec 9, 2018


Copy link

@davidism davidism commented Dec 9, 2018

Continues, closes #549

Previous PR only supported a fixed number of continuations in the filename parameter during form parsing. This moves continuation handling to parse_options_header, so any header and option will support continuations.

The RFC says that only the first line needs to specify an encoding, and the other lines should inherit it. We keep track of the encoding, but allow any continuation to change it, since it shouldn't really affect anything.

Each continuation has an index, but the RFC says they should only come in sequential order without gaps, so the index is ignored and the values are appended in the order they're seen.

taizo and others added 2 commits December 9, 2018 09:48
move continuation handling to parse_options_header
update regex to capture continuation index
update regex to make encoding optional
continuation keeps track of encoding
any number of continuations is allowed
add changelog
@davidism davidism added this to the 0.15 milestone Dec 9, 2018
@davidism davidism merged commit 2605b38 into master Dec 9, 2018
@davidism davidism deleted the rfc2231-parameter-continuation branch December 9, 2018 19:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants