Rfc2231 parameter continuation - #1417
Merged
Merged
Conversation
move continuation handling to parse_options_header update regex to capture continuation index update regex to make encoding optional continuation keeps track of encoding any number of continuations is allowed add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues, closes #549
Previous PR only supported a fixed number of continuations in the filename parameter during form parsing. This moves continuation handling to
parse_options_header, so any header and option will support continuations.The RFC says that only the first line needs to specify an encoding, and the other lines should inherit it. We keep track of the encoding, but allow any continuation to change it, since it shouldn't really affect anything.
Each continuation has an index, but the RFC says they should only come in sequential order without gaps, so the index is ignored and the values are appended in the order they're seen.