Catch ConnectionError instead of socket.error on Python 3 - #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 3151 made
socket.erroran alias ofOSErroron Python 3. Our server was catchingsocket.errorto silence client disconnects (and any other socket-related errors), but on Python 3 this silences allOSErrors.I'm not clear why
socket.erroris an alias forOSErrorinstead ofConnectionError. If that were the case, the code would have worked correctly without change. This section in PEP 3151 seems to imply the same.This change catches
ConnectionErroron Python 3, and continues to catchsocket.erroron Python 2. Additionally,handle_erroralso checks for socket errors, since they weren't completely silenced on Python 2.Closes #1127