Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutable CombinedMultiDict.copy() #1420

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
1 participant
@davidism
Copy link
Member

commented Dec 10, 2018

CombinedMultiDict is immutable, and its copy returns another CombinedMultiDict wrapping the same dicts. However, other immutable multi-dicts return mutable copies. And a copy is generally not expected to stay in sync with its original. This changes CombinedMultiDict.copy to return a MultiDict.

Closes #951

@davidism davidism added this to the 0.15 milestone Dec 10, 2018

@davidism davidism force-pushed the combined-copy branch from f8c0ec9 to b26fd69 Dec 10, 2018

@davidism davidism merged commit a59f1e0 into master Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidism davidism deleted the combined-copy branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.