Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoting in uri_to_iri and iri_to_uri #1433

Merged
merged 3 commits into from Jan 12, 2019
Merged

Fix quoting in uri_to_iri and iri_to_uri #1433

merged 3 commits into from Jan 12, 2019

Conversation

@davidism
Copy link
Member

@davidism davidism commented Jan 12, 2019

uri_to_iri more closely matches the process in RFC 3987. All ASCII bytes that aren't in unreserved should remain quoted. Any bytes that do not decode to UTF-8 (or whatever charset is passed in Werkzeug's case) are re-quoted rather than being replaced. Closes #1356.

iri_to_uri does not quote any unquoted reserved characters in the URL, rather than just the subset it preserved before. Closes #402.

davidism added 2 commits Jan 12, 2019
all reserved and invalid characters in are left quoted
unquote caches conversion maps
@davidism davidism added this to the 0.15 milestone Jan 12, 2019
reserved characters are not quoted
@davidism davidism force-pushed the uri_iri_quoting branch from 91b7246 to ff9ee21 Jan 12, 2019
@davidism davidism merged commit ce162fc into master Jan 12, 2019
1 check passed
@davidism davidism deleted the uri_iri_quoting branch Jan 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant