Fix quoting in uri_to_iri and iri_to_uri - #1433
Merged
Merged
Conversation
all reserved and invalid characters in are left quoted unquote caches conversion maps
reserved characters are not quoted
davidism
force-pushed
the
uri_iri_quoting
branch
from
January 12, 2019 19:07
91b7246 to
ff9ee21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uri_to_irimore closely matches the process in RFC 3987. All ASCII bytes that aren't inunreservedshould remain quoted. Any bytes that do not decode to UTF-8 (or whatever charset is passed in Werkzeug's case) are re-quoted rather than being replaced. Closes #1356.iri_to_uridoes not quote any unquoted reserved characters in the URL, rather than just the subset it preserved before. Closes #402.