Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split wrappers #1456

Merged
merged 31 commits into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@davidism
Copy link
Member

commented Feb 11, 2019

Closes #1450

Used https://github.com/potherca-bash/git-split-file to preserve the commit history so blame still works for each file. That's the reason for so many commits, it creates a branch to rename __init__.py to each split file.

werkzeug.wrappers still exports all the classes, the documentation remains the same. The understanding is that the documented API was the publicly importable API. However, none of the incidental imports are exposed at the top level any more, so anything that was behaving badly and importing werkzeug.wrappers.datetime, etc. will need to update.

@davidism davidism added this to the 0.15 milestone Feb 11, 2019

@ThiefMaster

This comment was marked as resolved.

Copy link
Member

commented Feb 11, 2019

Any way to s/Changes/Change/ in those commit messages that are probably created by a script?

davidism added some commits Feb 12, 2019

davidism added some commits Feb 12, 2019

@davidism davidism force-pushed the split-wrappers branch from 3a38445 to 102b8dc Feb 12, 2019

@davidism davidism merged commit 36ed800 into master Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidism davidism deleted the split-wrappers branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.