Skip to content

Split wrappers #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Feb 12, 2019
Merged

Split wrappers #1456

merged 31 commits into from
Feb 12, 2019

Conversation

davidism
Copy link
Member

Closes #1450

Used https://github.com/potherca-bash/git-split-file to preserve the commit history so blame still works for each file. That's the reason for so many commits, it creates a branch to rename __init__.py to each split file.

werkzeug.wrappers still exports all the classes, the documentation remains the same. The understanding is that the documented API was the publicly importable API. However, none of the incidental imports are exposed at the top level any more, so anything that was behaving badly and importing werkzeug.wrappers.datetime, etc. will need to update.

@davidism davidism added this to the 0.15 milestone Feb 11, 2019
@ThiefMaster

This comment has been minimized.

@davidism davidism merged commit 36ed800 into master Feb 12, 2019
@davidism davidism deleted the split-wrappers branch February 12, 2019 05:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split up wrappers
2 participants