Added charset to HTTPException header content-type#1526
Merged
Conversation
yangineer
force-pushed
the
adds_charset_to_header
branch
from
0a690a0 to
de27bc5
Compare
yangineer
changed the title
davidism
force-pushed
the
adds_charset_to_header
branch
from
23dc0d0 to
2a8d55d
Compare
davidism
changed the title
davidism
force-pushed
the
adds_charset_to_header
branch
from
2a8d55d to
11d5be7
Compare
Contributor
Author
|
Tried to re-trigger Travis build by closing and opening PR but that didn't work... |
yangineer
force-pushed
the
adds_charset_to_header
branch
from
11d5be7 to
a68c1df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
charset=utf-8to Header['Content-Type'] for HTTPException's response.It looks like the template HTML body is in unicode, so we should set the charset explicitly so that Browsers will pick the correct one.