Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added charset to HTTPException header content-type #1526

Merged
merged 1 commit into from May 12, 2019

Conversation

yangineer
Copy link
Contributor

@yangineer yangineer commented May 3, 2019

Adds charset=utf-8 to Header['Content-Type'] for HTTPException's response.

It looks like the template HTML body is in unicode, so we should set the charset explicitly so that Browsers will pick the correct one.

@yangineer yangineer force-pushed the adds_charset_to_header branch from 0a690a0 to de27bc5 Compare May 3, 2019
@yangineer yangineer changed the title Added charset to HTTPException header content-type Added charset to HTTPException header content-type, fixed style issues from flake8-bugbear May 3, 2019
@davidism davidism force-pushed the adds_charset_to_header branch from 23dc0d0 to 2a8d55d Compare May 8, 2019
@davidism davidism changed the base branch from master to 0.15.x May 8, 2019
@davidism davidism changed the title Added charset to HTTPException header content-type, fixed style issues from flake8-bugbear Added charset to HTTPException header content-type May 8, 2019
@davidism davidism force-pushed the adds_charset_to_header branch from 2a8d55d to 11d5be7 Compare May 8, 2019
@davidism davidism changed the base branch from 0.15.x to master May 8, 2019
@davidism davidism added this to the 1.0 milestone May 8, 2019
@yangineer yangineer closed this May 9, 2019
@yangineer yangineer reopened this May 9, 2019
@yangineer
Copy link
Contributor Author

@yangineer yangineer commented May 9, 2019

Tried to re-trigger Travis build by closing and opening PR but that didn't work...

@yangineer yangineer force-pushed the adds_charset_to_header branch from 11d5be7 to a68c1df Compare May 9, 2019
@davidism davidism merged commit f6b72e8 into pallets:master May 12, 2019
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants