Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break cycle in chained exceptions #1540

Merged
merged 1 commit into from May 12, 2019

Conversation

@davidism
Copy link
Member

davidism commented May 12, 2019

closes #1536

The traceback formatter followed exc_value.__context__ infinitely, even if there was a cycle. Add a memo set to track what's been seen already and break when it detects a cycle.

@davidism davidism added the debugger label May 12, 2019
@davidism davidism added this to the 0.15.3 milestone May 12, 2019
@davidism davidism merged commit bdc17e4 into 0.15.x May 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davidism davidism deleted the break-tb-cycle branch May 12, 2019
while True:
self.groups.append(Group(exc_type, exc_value, tb))
memo.add(exc_value)

This comment has been minimized.

Copy link
@asottile

asottile May 12, 2019

Contributor

this assumes hashability of exceptions (which isn't always true), I wrote a fix for this: #1542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.