Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match server names with default scheme and port #1584

Merged
merged 1 commit into from Jun 11, 2019
Merged

match server names with default scheme and port #1584

merged 1 commit into from Jun 11, 2019

Conversation

davidism
Copy link
Member

If the configured server name has a port that matches the scheme of the incoming WSGI server name, it will match successfully. Previously, specifying localhost:443 wouldn't match https://localhost.

Discovered while fixing some warnings generated in the Flask test suite after #1577.

@davidism davidism added this to the 1.0.0 milestone Jun 10, 2019
jab
jab approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@jab jab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@davidism davidism merged commit b81aa0f into master Jun 11, 2019
@davidism davidism deleted the server-name branch June 11, 2019 15:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jab jab jab approved these changes

Assignees
No one assigned
Labels
bug routing
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidism @jab