Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements case-insensitive header equality #1605

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Implements case-insensitive header equality #1605

merged 2 commits into from
Jul 11, 2019

Conversation

markmcd
Copy link
Contributor

@markmcd markmcd commented Jul 10, 2019

Currently this fails:

assert datastructures.Headers({'X-Foo': 'fu'}) == datastructures.Headers({'x-foo': 'fu'})

The Headers class otherwise respects the case insensitivity of keys, this patch just extends this to the equality check.

@markmcd

This comment has been minimized.

Sign in to view
@davidism davidism force-pushed the header-sensitivity branch from 06a9865 to 889b1a2 Compare July 10, 2019 21:01
@davidism davidism force-pushed the header-sensitivity branch from 889b1a2 to c13eba6 Compare July 10, 2019 21:45
@davidism davidism added this to the 1.0.0 milestone Jul 10, 2019
@davidism
Copy link
Member

Needs changelog.

@markmcd
Copy link
Contributor Author

markmcd commented Jul 11, 2019

Changelog added in a new commit. I can squash these if necessary.

@davidism davidism merged commit 892545d into pallets:master Jul 11, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markmcd @davidism