remove lazy importer, fix circular imports #1640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2
Given that everything is so circular, importing anything basically resulted in importing everything anyway, so there wasn't really a point to the lazy importer.
Moved some imports into the functions that need them in order to break circular imports. Only
httpanddatastructuresimport from each other at the bottom of the modules now, as they both do about the same amount of importing, so making one lazy didn't make sense.Verified this by doing
subprocess.run(["python", "-c", "import {name}"])for every module in Werkzeug. None resulted in import errors.