Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing RFC HTTP status codes #1678

Merged
merged 1 commit into from Jan 5, 2020

Conversation

adeharo9
Copy link
Contributor

@adeharo9 adeharo9 commented Dec 3, 2019

I haven't created an issue on the repo since this is actually not an issue, but more of a completion work.

I have added RFC HTTP status codes 103, 208, 306, 425, 506, 508 and 511 with the respective comments to the corresponding RFC documents for completion (except the 306 status code, which is unused, but I have added it for compatibility purposes).

Hope I'm contributing the right way to the project!

@davidism
Copy link
Member

@davidism davidism commented Jan 3, 2020

Why is this change needed? You'll need to include a test demonstrating the issue you had that this fixes. See #1389 for general thoughts on status codes.

@pgjones
Copy link
Member

@pgjones pgjones commented Jan 4, 2020

Some of these (208, 506, 508 and 511) are present in the stdlib which I think would be justification to include in Werkzeug.

@davidism
Copy link
Member

@davidism davidism commented Jan 5, 2020

After thinking about this, I guess it's fine to merge these, in part because you documented where they come from, although in the future I'd like more justification for needing them.

@davidism davidism force-pushed the add-missing-rfc-codes branch from 8359ed5 to 2d4c4c7 Compare Jan 5, 2020
@davidism davidism merged commit e069cdb into pallets:master Jan 5, 2020
12 checks passed
@davidism davidism added this to the 1.0.0 milestone Jan 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants