Adds missing RFC HTTP status codes #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this change needed? You'll need to include a test demonstrating the issue you had that this fixes. See #1389 for general thoughts on status codes. |
|
Some of these (208, 506, 508 and 511) are present in the stdlib which I think would be justification to include in Werkzeug. |
|
After thinking about this, I guess it's fine to merge these, in part because you documented where they come from, although in the future I'd like more justification for needing them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't created an issue on the repo since this is actually not an issue, but more of a completion work.
I have added RFC HTTP status codes 103, 208, 306, 425, 506, 508 and 511 with the respective comments to the corresponding RFC documents for completion (except the 306 status code, which is unused, but I have added it for compatibility purposes).
Hope I'm contributing the right way to the project!