Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow a single Allow Origin (Access Control) value #1723

Merged
merged 1 commit into from Feb 9, 2020

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Feb 8, 2020

The relevant specification text is,

Rather than allowing a space-separated list of origins, it is
either a single origin or the string "null".[0]

and

Note: null should not be used[1]

it is clear that the previous HeaderSet usage was wrong. (Also note
that the value is case sensitive)[0].

0: https://www.w3.org/TR/cors/
1: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin

The relevant specification text is,

    Rather than allowing a space-separated list of origins, it is
    either a single origin or the string "null".[0]

and

    Note: null should not be used[1]

it is clear that the previous HeaderSet usage was wrong. (Also note
that the value is case sensitive)[0].

[0]: https://www.w3.org/TR/cors/
[1]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin
@davidism davidism merged commit efe2377 into pallets:1.0.x Feb 9, 2020
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants