Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle setting invalid status on response consistently #1728

Merged
merged 2 commits into from Mar 17, 2020
Merged

Handle setting invalid status on response consistently #1728

merged 2 commits into from Mar 17, 2020

Conversation

raymond-devries
Copy link
Contributor

@raymond-devries raymond-devries commented Feb 10, 2020 •
edited by davidism

Status setter now properly calls status code setter instead of setting status code directly.

fixes #1658

@davidism davidism force-pushed the resp_allows_invalid_status_#1658 branch from 3da331a to e245cf6 Compare February 10, 2020 23:22
@raymond-devries raymond-devries force-pushed the resp_allows_invalid_status_#1658 branch 5 times, most recently from 5643480 to ef80905 Compare February 11, 2020 04:23
@raymond-devries

This comment has been minimized.

Sign in to view
@raymond-devries raymond-devries force-pushed the resp_allows_invalid_status_#1658 branch 2 times, most recently from 739893f to df0683e Compare February 11, 2020 08:08
@ThiefMaster

This comment has been minimized.

Sign in to view
@raymond-devries raymond-devries force-pushed the resp_allows_invalid_status_#1658 branch 5 times, most recently from d6a745f to 1b83715 Compare February 11, 2020 16:54
@lathamfell lathamfell force-pushed the resp_allows_invalid_status_#1658 branch from 1b83715 to 4edf48f Compare February 12, 2020 00:20
@raymond-devries

This comment has been minimized.

Sign in to view
@raymond-devries raymond-devries force-pushed the resp_allows_invalid_status_#1658 branch 2 times, most recently from 21f898d to 7dd0c96 Compare February 12, 2020 19:46
@davidism davidism changed the title Fixes Resp allows invalid status #1658 Handle setting invalid status on response consistently Feb 12, 2020
@davidism davidism force-pushed the resp_allows_invalid_status_#1658 branch from 7dd0c96 to 30b968e Compare March 17, 2020 16:36
@davidism davidism changed the base branch from 1.0.x to master March 17, 2020 16:36
@davidism davidism added this to the 2.0.0 milestone Mar 17, 2020
@davidism davidism merged commit be2b4ac into pallets:master Mar 17, 2020
@davidism
Copy link
Member

Thanks for working on this at the PyCascades sprint! I refactored _clean_status so it's only one method, and rebased onto master. This will be in 2.0.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Response allows invalid status
3 participants
@raymond-devries @ThiefMaster @davidism