Bugfix accept additional attributes to the delete cookie #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgjones
commented
Jul 26, 2020
|
Thoughts on updating the test server's method in this PR as well? Line 886 in b45ac05 The changes to the test server should be identical so it'll be cleaner all together rather than separate PRs. These changes look good to me and are necessary for pallets/flask#3726. |
Member
Author
|
@darcatron thanks, I've done so. |
davidism
reviewed
Oct 7, 2020
Member
davidism
left a comment
davidism
left a comment
There was a problem hiding this comment.
Needs a changelog, otherwise looks fine.
davidism
force-pushed
the
delete_cookie
branch
from
2cccba0 to
e78bded
Compare
Recent browser changes mean that cookies will not be set if they have the wrong combination of attributes e.g. SameSite none and not secure. This also affects deletion which itself is a set cookie command. Only the SameSite and secure attributes are required, however it seems more useful to accept all the possibilities for other edge cases. See also https://chromestatus.com/feature/5633521622188032
davidism
force-pushed
the
delete_cookie
branch
from
e78bded to
7483127
Compare
davidism
approved these changes
Oct 14, 2020
Member
Author
|
Thanks 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent browser changes mean that cookies will not be set if they have
the wrong combination of attributes e.g. SameSite none and not
secure. This also affects deletion which itself is a set cookie
command.
Only the SameSite and secure attributes are required, however it seems
more useful to accept all the possibilities for other edge cases.
See also https://chromestatus.com/feature/5633521622188032
See also https://www.thinktecture.com/en/identity/samesite/how-to-delete-samesite-cookies/