Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent crash if stdin is None. #1915

Merged
merged 1 commit into from Oct 14, 2020
Merged

prevent crash if stdin is None. #1915

merged 1 commit into from Oct 14, 2020

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Aug 16, 2020

This can happen if you use external tools like entr to reload the server, then sys.stdin can be None, and one uses run(debug=True).

@davidism
Copy link
Member

This looks fine, although I'm surprised sys.stdin can be None. Were you waiting for something before marking this ready?

@davidism davidism marked this pull request as ready for review October 14, 2020 17:26
@davidism
Copy link
Member

davidism commented Oct 14, 2020

I've found some other references to this issue with the same fix, I'll go ahead and add a changelog and merge this.

@davidism davidism added this to the 2.0.0 milestone Oct 14, 2020
@davidism davidism merged commit 84f39d9 into pallets:master Oct 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants