Enhance generation of password hashes - #1935
Merged
davidism merged 1 commit intoOct 14, 2020
Merged
Conversation
Member
|
How did you arrive at the new value of 26000 rounds? What is the reasoning behind increasing the salt length, and why 16? |
Contributor
Author
I am sorry for not specifying this in the description of the PR, I added reasons to description of the commits. We increased the number of iterations last time two years ago and got it from Django (#1377). This time the number is the same as Django uses too (django/django@2185007). 16 characters are recommended by OWASP: https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#salting. |
Member
|
OK, thanks. Don't worry about the test failure, I need to investigate that separately. |
Increase the number of PBKDF2 iterations to 260000. Matches Django's latest value: django/django@2185007 Increase salt length to 16 characters following an OWASP recommendation: https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#salting Use the secrets module for generating the salt: https://docs.python.org/3/library/secrets.html#recipes-and-best-practices
davidism
force-pushed
the
password-generation-enhancements
branch
from
October 14, 2020 16:42
f87443c to
7729a62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.