Log SSL errors before discarding them#1967
Merged
davidism merged 1 commit intopallets:masterfrom Jan 10, 2021
Merged
Conversation
4b1ceb0 to
fb745af
Compare
Co-authored-by: Jonathan Reed <jdreed@mit.edu>
fb745af to
1c2c18e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of simply discarding SSL errors, log them before.
Based on #694 by @jdreed
Fixes #625
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.I could not add a test because I keep running into this problem when following the instructions given in CONTRIBUTING.rst:
If I install werkzeug manually, I get another error:
Environment: