Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.values ignores form data for GET #2037

merged 1 commit into from Feb 9, 2021

request.values ignores form data for GET #2037

merged 1 commit into from Feb 9, 2021


Copy link

@davidism davidism commented Feb 9, 2021

request.values combines request.args and request.form. GET requests can have form bodies (although it's undefined / ambiguous in specs). Poorly implemented caching proxies may not understand that GET requests can have form data, which would allow form data to invisibly affect a public cached URL.

Now request.values won't use request.form if request.method == "GET".


  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 2.0.0 milestone Feb 9, 2021
@davidism davidism merged commit e6a3346 into master Feb 9, 2021
1 check passed
@davidism davidism deleted the values-get branch February 9, 2021 22:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant