Skip to content

request.values ignores form data for GET#2037

Merged
davidism merged 1 commit into
masterfrom
values-get
Feb 9, 2021
Merged

request.values ignores form data for GET#2037
davidism merged 1 commit into
masterfrom
values-get

Conversation

@davidism
Copy link
Copy Markdown
Member

@davidism davidism commented Feb 9, 2021

request.values combines request.args and request.form. GET requests can have form bodies (although it's undefined / ambiguous in specs). Poorly implemented caching proxies may not understand that GET requests can have form data, which would allow form data to invisibly affect a public cached URL.

Now request.values won't use request.form if request.method == "GET".

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 2.0.0 milestone Feb 9, 2021
@davidism davidism merged commit e6a3346 into master Feb 9, 2021
@davidism davidism deleted the values-get branch February 9, 2021 22:55
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant