Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: set appropriate secure flag on cookie #2150

Merged
merged 1 commit into from Jun 1, 2021
Merged

debugger: set appropriate secure flag on cookie #2150

merged 1 commit into from Jun 1, 2021

Conversation

brondsem
Copy link
Contributor

When using the debugger on an https site, Chrome was refusing to use the cookie.

Related to #1912 but for https/secure now.

  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism
Copy link
Member

I understand you can run the development server over HTTPS, but to be very clear: no one should be running the development server, and especially the debugger, in production, which is when HTTPS is normally used.

@davidism
Copy link
Member

This is missing a changelog entry, which was one of the checkboxes you removed.

@brondsem
Copy link
Contributor Author

Yes my development server uses https; not using the debugger in production 😄

My bad, I've added a commit with the changelog entry.

@davidism
Copy link
Member

Please rebase this to 2.0.x, and squash work into a single commit.

git rebase -i --onto origin/2.0.x origin/main
git push -f

@davidism davidism changed the base branch from main to 2.0.x May 27, 2021 19:41
@brondsem
Copy link
Contributor Author

Sure thing, done

@pgjones pgjones merged commit 5098a06 into pallets:2.0.x Jun 1, 2021
@davidism davidism added this to the 2.0.2 milestone Jun 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants