Skip to content

Expand frame working only for first 10 frames - #2239

Merged
davidism merged 1 commit into
pallets:2.0.xfrom
mireq:main
Oct 6, 2021
Merged

davidism merged 1 commit into
pallets:2.0.xfrom
mireq:main

Conversation

@mireq

@mireq mireq commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

Click handler finds n-th (n is frame depth) line of frame and expands parent. Default are 10 lines visible. If depth is higher browser raises:

Uncaught TypeError: frame.getElementsByTagName(...)[i] is undefined
    addToggleFrameTraceback http://localhost:8000/?__debugger__=yes&cmd=resource&f=debugger.js:26

@davidism

Copy link
Copy Markdown
Member

Please rebase this to 2.0.x:

git rebase --onto origin/2.0.x origin/main
git push -f

Then change the target of this PR using the edit button to the right of the title.

@mireq
mireq changed the base branch from main to 2.0.x September 29, 2021 15:39
@davidism davidism added this to the 2.0.2 milestone Oct 5, 2021
@davidism
davidism merged commit 41eefbf into pallets:2.0.x Oct 6, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants