Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use socket.fromfd #2287

Merged
merged 1 commit into from
Nov 16, 2021
Merged

always use socket.fromfd #2287

merged 1 commit into from
Nov 16, 2021

Conversation

davidism
Copy link
Member

All supported versions of Python have socket.fromfd. The check for Windows from #1081 for #993 doesn't appear to be required any longer, I tested socket.fromfd on Python 3.7 on Windows and it works fine.

@davidism davidism added this to the 2.1.0 milestone Nov 16, 2021
@davidism davidism merged commit df7492a into main Nov 16, 2021
@davidism davidism deleted the socket-fromfd branch November 16, 2021 21:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant