Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotation for reqeust_or_environ parameters #2290

merged 1 commit into from
Dec 23, 2021


Copy link

@zjmil zjmil commented Dec 1, 2021

Small update to the type annotation of the request_or_environ parameter of Request.make_conditional to accept a Request in addition to a WSGIEnvironment (as the name suggests).

  • fixes #


  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 2.0.3 milestone Dec 23, 2021
@davidism davidism changed the base branch from main to 2.0.x December 23, 2021 16:11
@davidism davidism changed the title Fix type annotation for Request.make_conditional Fix type annotation for reqeust_or_environ parameters Dec 23, 2021
@davidism davidism merged commit 0e11fab into pallets:2.0.x Dec 23, 2021
@zjmil zjmil deleted the fix-make-conditional-typing branch December 23, 2021 16:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants