Change how relative redirects are converted to absolute #693 #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM but please add tests. |
Contributor
Author
|
Sorry about that, I forgot to read your contribution guidelines. |
Contributor
|
I'm no longer sure this is a good idea. @mitsuhiko? |
Member
|
Closing due to age and no description of what the issue was. Please open a new ticket to discuss if you still need this. |
Member
|
Oops, found the explanation in #693, but looks like your branch doesn't exist anymore so I can't reopen the PR. The last comment there says the latest RFC supports this, so I think this is reasonable. I'll cherry-pick this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.