Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how relative redirects are converted to absolute #693 #718

Closed
wants to merge 2 commits into from
Closed

Change how relative redirects are converted to absolute #693 #718

wants to merge 2 commits into from

Conversation

@boblehest
Copy link
Contributor

@boblehest boblehest commented Mar 26, 2015

No description provided.

@untitaker
Copy link
Member

@untitaker untitaker commented Apr 4, 2015

LGTM but please add tests.

@boblehest
Copy link
Contributor Author

@boblehest boblehest commented Apr 6, 2015

Sorry about that, I forgot to read your contribution guidelines.

@untitaker untitaker self-assigned this Apr 10, 2016
@untitaker
Copy link
Member

@untitaker untitaker commented Apr 10, 2016

I'm no longer sure this is a good idea. @mitsuhiko?

@untitaker untitaker assigned mitsuhiko and unassigned untitaker Apr 10, 2016
@davidism
Copy link
Member

@davidism davidism commented May 22, 2018

Closing due to age and no description of what the issue was. Please open a new ticket to discuss if you still need this.

@davidism davidism closed this May 22, 2018
@davidism
Copy link
Member

@davidism davidism commented May 28, 2018

Oops, found the explanation in #693, but looks like your branch doesn't exist anymore so I can't reopen the PR. The last comment there says the latest RFC supports this, so I think this is reasonable. I'll cherry-pick this.

@davidism davidism added this to the 0.15 milestone May 28, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants