Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how relative redirects are converted to absolute #693 #718

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@boblehest
Copy link
Contributor

commented Mar 26, 2015

No description provided.

@untitaker

This comment has been minimized.

Copy link
Member

commented Apr 4, 2015

LGTM but please add tests.

@untitaker untitaker added the needs work label Apr 4, 2015

@boblehest

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2015

Sorry about that, I forgot to read your contribution guidelines.

@untitaker untitaker added needs review and removed needs work labels Apr 6, 2015

@untitaker untitaker added the ready label Mar 29, 2016

@untitaker untitaker self-assigned this Apr 10, 2016

@untitaker

This comment has been minimized.

Copy link
Member

commented Apr 10, 2016

I'm no longer sure this is a good idea. @mitsuhiko?

@untitaker untitaker assigned mitsuhiko and unassigned untitaker Apr 10, 2016

@davidism

This comment has been minimized.

Copy link
Member

commented May 22, 2018

Closing due to age and no description of what the issue was. Please open a new ticket to discuss if you still need this.

@davidism davidism closed this May 22, 2018

@davidism

This comment has been minimized.

Copy link
Member

commented May 28, 2018

Oops, found the explanation in #693, but looks like your branch doesn't exist anymore so I can't reopen the PR. The last comment there says the latest RFC supports this, so I think this is reasonable. I'll cherry-pick this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.