Set the default path_info to the root '/' #768
Conversation
Set the default path_info to the root '/'
Add test for PR #1 and issue pallets#740
|
@zhaoguixu Those tests fail for me. Could you take a look? Thanks! |
Fixed the new added test ``` test_both_bind_and_match_path_info_are_none``` to avoid failures
Update test_routing.py by fixing new added test ```test_both_bind_and_match_path_info_are_none```
|
This should be good. @untitaker |
|
Please run Will review content later. |
| self.map.update() | ||
| if path_info is None: | ||
| path_info = self.path_info | ||
| path_info = self.path_info or u'/' |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I don't really understand why you need this behavior in the first place. In which situation would you call |
|
Both the default value of |
|
I think it was intended to just have no implicit default at all. That this is expressed with a 404 is unfortunate. |
|
I am not very familiar with the whole logic. I just test the two combined in one situation and it gives me a trackback. Feel free to decide whether this fix is necessary. |
Adjust styles.
|
Delegating to @mitsuhiko, because I don't really know. |
|
continued in #1316 |
4 participants
Set the default path_info to the root '/' when both the path_info passed to 'bind' and 'match' are None.
#740