Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pruning until an item "fits"... #3

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Came across this via a tweet from @joemccann ... saw your TODO, thought perhaps this fix would be applicable? :-) Any thoughts?

Cheers!

  • Clint
Owner

pamelafox commented Apr 19, 2011

Thanks for this! - A few questions:

  1. Can you explain line 55 to me further? When does that situation happen?
  2. Have you tested this out? It would be useful to add a test HTML file that actually demonstrates going over quota and what happens as a result. (And yes, it's something I should have added myself- but since you suggested this change, perhaps you've put a test together).

Howdy!

  1. I don't know if that would actually happen or not, but it seemed like an edge case to cover?
  2. I'm working on an HTML file to test, though I did test in the console. I'm hoping to have it this weekend when I have more time?

I noticed a few other folks had pull requests on this topic; you might look over them and arrive at some kind of hybrid?

In any case, this is going to come in handy for me later down the road... hopefully this helps! Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment