{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":519250394,"defaultBranch":"master","name":"egui","ownerLogin":"pan93412","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-07-29T14:46:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/28441561?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1685969957.026502","currentOid":""},"activityList":{"items":[{"before":"e472929a62f02936b1f42cc7eff46f969e359262","after":null,"ref":"refs/heads/fix-observer-removal-issue","pushedAt":"2023-06-05T12:59:17.026Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pan93412","name":"pan93412","path":"/pan93412","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28441561?s=80&v=4"}},{"before":"09c0e2a96304b04fb4620fb5ad913accdef4296e","after":"e472929a62f02936b1f42cc7eff46f969e359262","ref":"refs/heads/fix-observer-removal-issue","pushedAt":"2023-06-04T06:03:36.190Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pan93412","name":"pan93412","path":"/pan93412","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28441561?s=80&v=4"},"commit":{"message":"eframe: Only run_return twice on Windows\n\nThe approach of #1889 may remove observers in a view\ntwice, which produces the Obj-C Exception:\n\n    Cannot remove an observer <...> for the key path\n    \"nextResponder\" from <WinitView ...> because\n    it is not registered as an observer.\n\nThe above message can only be seen when attaching the\napplication to debugger. Users normally see:\n\n    [1]    *** trace trap  cargo run\n\nThis commit fixes it by only running `event_loop.run_return()`\ntwice on Windows. Besides:\n\n* We have set `ControlFlow::Exit` on `Event::LoopDestroyed`,\n  `EventResult::Exit` and on error; therefore, it is safe\n  to not calling `set_exit()`.\n* This commit also fix the persistence function in macOS.\n  It can't store the content in Memory due to this exception.\n\nFixed: #2768 (eframe: \"App quit unexpectedly\" on macOS)\nSigned-off-by: pan93412 <pan93412@gmail.com>","shortMessageHtmlLink":"eframe: Only run_return twice on Windows"}},{"before":null,"after":"09c0e2a96304b04fb4620fb5ad913accdef4296e","ref":"refs/heads/fix-observer-removal-issue","pushedAt":"2023-06-04T05:51:45.403Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pan93412","name":"pan93412","path":"/pan93412","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28441561?s=80&v=4"},"commit":{"message":"eframe: Only run_return twice on Windows\n\nThe approach of #1889 may remove the observer of a view\ntwice, which produces the Obj-C Exception:\n\n    Cannot remove an observer <...> for the key path\n    \"nextResponder\" from <WinitView ...> because\n    it is not registered as an observer.\n\nThe above message can only be seen when attaching the\napplication to debugger. Users normally see:\n\n    [1]    *** trace trap  cargo run\n\nThis commit fixes it by only running event_loop twice\non Windows. Besides:\n\n* We have set ControlFlow::Exit on 'Event::LoopDestoryed',\n  'EventResult::Exit' and on error; therefore, it is safe\n  to not calling `set_exit()`.\n* This commit also fix the persistence function in macOS.\n  It can't store the content in Memory due to this exception.\n\nFixed: #2768 (eframe: \"App quit unexpectedly\" on macOS)\nSigned-off-by: pan93412 <pan93412@gmail.com>","shortMessageHtmlLink":"eframe: Only run_return twice on Windows"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADOudmGwA","startCursor":null,"endCursor":null}},"title":"Activity · pan93412/egui"}