Permalink
Commits on Feb 17, 2018
  1. Improve tests with AssumptionViolatedExceptions

    stefanbirkner committed Feb 15, 2018
    The expectations that the test are failing and not being skipped is now
    explicit.
  2. Add some missing tests

    stefanbirkner committed Feb 15, 2018
  3. Run ErrorCollectorTest with Parameterized runner

    stefanbirkner committed Feb 15, 2018
    The array for the Parameterized gives a better overview of the tests.
  4. Add test for handling InitializationError

    stefanbirkner and acanda committed Feb 15, 2018
    The code was changed by commit 0804ef4
    but unfortunately the test was not part of the commit. The test is based
    on Philip Graf's test in pull request #1065.
    
    Co-authored-by: Philip Graf <git@acanda.ch>
Commits on Feb 14, 2018
  1. Separate VerifierRuleTest and ErrorCollectorTest

    stefanbirkner committed Feb 14, 2018
    It is a common practice to collect the tests for a class in a test class
    whose name is equal to the class' name but with a suffix `Test`.
    Therefore having all tests for `ErrorCollector` in a class named
    `ErrorCollectorTest` makes it easier for people to find them (principle
    of least astonishment).
Commits on Feb 8, 2018
  1. Improve expressiveness of test name

    stefanbirkner committed Feb 8, 2018
    The test name "beforesAndAftersAreEnclosedByRule" reflects the purpose
    of the test better than "methodBeforesAndAfters".
  2. Delete unnecessary semicolons

    stefanbirkner committed Feb 7, 2018
    These semicolons are the source of distracting warnings in the IDE.
Commits on Dec 31, 2017
  1. Revert "Fluent expectations for ExpectedException".

    kcooney authored and stefanbirkner committed Dec 31, 2017
    The change was not binary compatible with JUnit 4.12.
    In addition, the preferred way to check for exceptions
    in JUnit 4.13 is with Assert.assertThrows() so we will
    be not adding new major features to ExpectedException.
    
    This reverts commit 1db00d5.
Commits on Dec 11, 2017
Commits on Oct 16, 2017
  1. Don't build with Oracle JDK 7 on Travis anymore

    stefanbirkner committed Oct 16, 2017
    Travis switched from Ubuntu Precise images to Ubuntu Trusty images. The
    Trusty images don't have installed Oracle JDK 7. See
    travis-ci/travis-ci#7884 We still build JUnit 4 with OpenJDK 7.
    Therefore it is fine to not build it with Oracle JDK 7.
  2. Install OpenJDK 6 on Travis

    stefanbirkner committed Oct 7, 2017
    Travis switched from Ubuntu Precise images to Ubuntu Trusty images. The
    Trusty images don't have installed OpenJDK 6 by default. See
    travis-ci/travis-ci#8199
  3. Build with Maven 3.1.1 (using Maven Wrapper)

    stefanbirkner committed Oct 15, 2017
    This makes the build independent from the Maven version that is
    installed on the build machine. E.g. Travis has Maven 3.5.6 installed
    that does not support Java 6 anymore.
    
    Maven version 3.1.1 is used because all newer version don't support
    Java 1.5.
Commits on Aug 22, 2017
Commits on Aug 8, 2017
  1. Fix dead link to the ant task in FAQ (#1478)

    rybak authored and kcooney committed Aug 8, 2017
    Documentation to the ant junit task has been moved to another location.
Commits on Aug 7, 2017
  1. deprecate RuleChain

    panchenko authored and kcooney committed May 25, 2017
    Closes #1445
Commits on Jul 29, 2017
Commits on Jun 23, 2017
  1. Provide helpful message if parameter cannot be set.

    stefanbirkner committed Jun 13, 2017
    For private @Parameter fields is users get an exception like
    "java.lang.IllegalAccessException: Class ... can not access a member
    of class X with modifiers private" The new message "Cannot set
    parameter 'parameter'. Ensure that the the field 'parameter' is
    public." tells the user what they should do.
    
    The reason for adding this feature is the Stackoverflow question
    https://stackoverflow.com/questions/44522046/reflection-exception-in-parameterized-junit-test-using-array-parameter/44522988
Commits on Jun 14, 2017
Commits on Jun 13, 2017
Commits on Jun 8, 2017
Commits on May 26, 2017
Commits on May 25, 2017
  1. Update Theories to pass the TestClass to BlockJUnit4ClassRunner.

    kcooney committed May 5, 2017
    This avoids repeated class scanning.
  2. Reuse `TestClass` for parameterized tests.

    kcooney committed May 5, 2017
    The `BlockJUnit4ClassRunnerWithParameters` created a new instance of
    `TestClass` for each parameter set. This led to repeated class
    scanning and noticeable memory allocation. Reusing the `TestClass`
    avoids theses side effects.
    
    Fixes #1046.
  3. Remove fast-tests maven target.

    svzdvd authored and kcooney committed May 25, 2017
    Many of our tests store data in static fields, so the tests cannot be run in parallel.
    
    Fixes #1297
Commits on May 19, 2017
Commits on May 6, 2017
Commits on May 5, 2017
  1. Replace uses of synchronized(something) with ReentrantLock. (#1343)

    kcooney committed May 5, 2017
    In almost all cases, this is more efficent, especially if there is any
    contention on the locks.