Skip to content
Permalink
Browse files

collide: protect info print with is_info() check

This prevents an unnecessary sqrt
  • Loading branch information
rdb committed Mar 16, 2020
1 parent 880e956 commit b549133b3e0778a8fcb6c712c523aad0f11187cf
Showing with 6 additions and 4 deletions.
  1. +6 −4 panda/src/collide/collisionPolygon.cxx
@@ -440,10 +440,12 @@ test_intersection_from_sphere(const CollisionEntry &entry) const {
LVector3 normal = (has_effective_normal() && sphere->get_respect_effective_normal()) ? get_effective_normal() : get_normal();
#ifndef NDEBUG
if (!IS_THRESHOLD_EQUAL(normal.length_squared(), 1.0f, 0.001)) {
collide_cat.info()
<< "polygon within " << entry.get_into_node_path()
<< " has normal " << normal << " of length " << normal.length()
<< "\n";
if (collide_cat.is_info()) {
collide_cat.info()
<< "polygon within " << entry.get_into_node_path()
<< " has normal " << normal << " of length " << normal.length()
<< "\n";
}
normal.normalize();
}
#endif

0 comments on commit b549133

Please sign in to comment.
You can’t perform that action at this time.