Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcparser no longer compiles outside of panda #759

Closed
ksmit799 opened this issue Oct 23, 2019 · 2 comments
Closed

dcparser no longer compiles outside of panda #759

ksmit799 opened this issue Oct 23, 2019 · 2 comments
Assignees
Milestone

Comments

@ksmit799
Copy link
Contributor

@ksmit799 ksmit799 commented Oct 23, 2019

Commit e4f493b included the use of vector_uchar.h, which is internal to panda. The entire dcparser module is designed to be compiled outside of the panda environment (without WITHIN_PANDA defined). However, when attempting to compile the dcparser outside of panda (for a native panda otp server) that's no longer possible.

@rdb

This comment has been minimized.

Copy link
Member

@rdb rdb commented Oct 23, 2019

This has no high priority for us, but a patch would be welcome and easy to make. Just a matter of moving the include to dcbase.h under the WITHIN_PANDA case, and in the else case, defining typedef std::vector<unsigned char> vector_uchar;.

@rdb rdb added this to the 1.10.5 milestone Dec 29, 2019
@rdb rdb self-assigned this Dec 29, 2019
@rdb rdb closed this in 0972dfa Dec 30, 2019
@rdb

This comment has been minimized.

Copy link
Member

@rdb rdb commented Dec 30, 2019

I've committed some fixes for this, it was straightforward enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.