Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools: PACKAGE_DATA_DIRS in dist/commands.py is not used #779

Closed
el-dee opened this issue Nov 10, 2019 · 1 comment
Closed

setuptools: PACKAGE_DATA_DIRS in dist/commands.py is not used #779

el-dee opened this issue Nov 10, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@el-dee
Copy link
Contributor

@el-dee el-dee commented Nov 10, 2019

In dist/commands.y a variable PACKAGE_DATA_DIRS contains extra dirs for cefpython3 matplotlib, ...

PACKAGE_DATA_DIRS = {

However it is never used, so when including cefpython3 one has to copy the entries in their own setup.py file.

@Moguri Moguri self-assigned this Nov 11, 2019
@Moguri

This comment has been minimized.

Copy link
Collaborator

@Moguri Moguri commented Nov 11, 2019

I noticed this yesterday as well, and I was hoping I could get a fix in before someone else noticed. Loos like I wasn't fast enough. :)

Assigning this to myself to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.