Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shader::_error_flag not being set for GLSL shader compile errors #622

Closed
wants to merge 5 commits into from

Conversation

@Moguri
Copy link
Collaborator

commented Apr 13, 2019

This PR also adds some unit tests around compiling GLSL shaders.

@rdb
Copy link
Member

left a comment

Looks great! But I think Shader.load uses Panda-style paths, not OS-specific paths.

@Moguri Moguri requested a review from rdb May 14, 2019

@rdb rdb added this to the 1.10.4 milestone Aug 1, 2019

rdb added a commit that referenced this pull request Aug 1, 2019
@rdb

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Sorry, didn't notice that you updated this. Merged, with some whitespace fixes. Thanks!

@rdb rdb closed this Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.