Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
dcparser: Fix a typo where an unpacked uint64 or int64 might shave off a few bits #751
@rdb Highly unlikely. This only affects integers larger than 56-bit, and as-is the packing is mismatched with the unpacking code - if somebody else had encountered this, we'd have heard about it sooner. The users of this code are also only using it for networked purposes (afaik nobody serializes to nonvolatile storage using DCPacker) so any compatibility issues would be temporary anyway.
The only compatibility issue I could see is if there's a networked game that sends some 64-bit random seed and there are mixed clients running Panda versions before/after this change lands which end up disagreeing on the seed. My stance is that's a case that's unlikely enough, and easily resolved enough, that we can merge this without fear of inconvenience to our users.