New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept pathlib paths wherever a path/file is expected #11033

Closed
flying-sheep opened this Issue Sep 9, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@flying-sheep
Contributor

flying-sheep commented Sep 9, 2015

i’d like pd.read_table(some_path / 'filename.tsv') to work without going through str()

@jreback jreback added this to the Next Major Release milestone Sep 9, 2015

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Sep 9, 2015

Contributor

sure, these just need stringifing. want to do a pull-request?

Contributor

jreback commented Sep 9, 2015

sure, these just need stringifing. want to do a pull-request?

@flying-sheep

This comment has been minimized.

Show comment
Hide comment
@flying-sheep

flying-sheep Sep 9, 2015

Contributor

gladly, but we need to define how first:

  • stringify everything that isn’t file-like and try treating it as a path?

    (there might be a problem if some custom __str__ function of an accidentally passed object happens to be a valid path)

  • test for being a Path subclass?

    this might need backwards-sensible code like

    try:
        from pathlib import Path
    except:
        class Path: pass  # dummy for instance checks
    
    ...
    
    if isinstance(file_or_path, Path):
        file_or_path = str(file_or_path)
Contributor

flying-sheep commented Sep 9, 2015

gladly, but we need to define how first:

  • stringify everything that isn’t file-like and try treating it as a path?

    (there might be a problem if some custom __str__ function of an accidentally passed object happens to be a valid path)

  • test for being a Path subclass?

    this might need backwards-sensible code like

    try:
        from pathlib import Path
    except:
        class Path: pass  # dummy for instance checks
    
    ...
    
    if isinstance(file_or_path, Path):
        file_or_path = str(file_or_path)
@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Sep 9, 2015

Contributor

here is where all of this path inference is done (well not 100% sure of all but vast majority)

you can use several/both of those strategies (though keep in mind that other pathlib like libs exists, e.g. py.local.path is the big one).

so I think its probably safe to str(filepath_or_buffer) (if this is not a file-like) might just work, but some tests would be gr8.

Contributor

jreback commented Sep 9, 2015

here is where all of this path inference is done (well not 100% sure of all but vast majority)

you can use several/both of those strategies (though keep in mind that other pathlib like libs exists, e.g. py.local.path is the big one).

so I think its probably safe to str(filepath_or_buffer) (if this is not a file-like) might just work, but some tests would be gr8.

@flying-sheep

This comment has been minimized.

Show comment
Hide comment
@flying-sheep

flying-sheep Sep 9, 2015

Contributor

io has no tests. should i start a module?

Contributor

flying-sheep commented Sep 9, 2015

io has no tests. should i start a module?

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Sep 9, 2015

Contributor

all of the io tests are in their respective directory. however for this you can add in pandas/io/tests/test_common.py (ideally you can add for all of the major ones, e.g. excel,sql,hdf5,csv,json,stata)

Contributor

jreback commented Sep 9, 2015

all of the io tests are in their respective directory. however for this you can add in pandas/io/tests/test_common.py (ideally you can add for all of the major ones, e.g. excel,sql,hdf5,csv,json,stata)

@flying-sheep

This comment has been minimized.

Show comment
Hide comment
@flying-sheep

flying-sheep Sep 10, 2015

Contributor

the tests are a bit uninspired but yeah 😄

Contributor

flying-sheep commented Sep 10, 2015

the tests are a bit uninspired but yeah 😄

@jreback jreback added the Data IO label Sep 10, 2015

@jreback jreback modified the milestones: 0.17.1, Next Major Release Sep 20, 2015

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Oct 17, 2015

Contributor

closed by #11051

Contributor

jreback commented Oct 17, 2015

closed by #11051

@jreback jreback closed this Oct 17, 2015

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Oct 17, 2015

Contributor

@flying-sheep this is failing on windows (3.5, though prob same on 2.7)

your test case should have a platform based separator, i think
os.join(['foo','bar'])

can you do a pull-request for this (and test on windows if you can, if not I can do it)

thanks

======================================================================
FAIL: test_stringify_path_pathlib (pandas.io.tests.test_common.TestCommonIOCapabilities)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\Jeff Reback\pandas3.5\pandas\io\tests\test_common.py", line 46, in test_stringify_path_pathlib
    self.assertEqual(redundant_path, 'foo/bar')
AssertionError: 'foo\\bar' != 'foo/bar'
- foo\bar
?    ^
+ foo/bar
?    ^


----------------------------------------------------------------------
Ran 8244 tests in 340.876s```
Contributor

jreback commented Oct 17, 2015

@flying-sheep this is failing on windows (3.5, though prob same on 2.7)

your test case should have a platform based separator, i think
os.join(['foo','bar'])

can you do a pull-request for this (and test on windows if you can, if not I can do it)

thanks

======================================================================
FAIL: test_stringify_path_pathlib (pandas.io.tests.test_common.TestCommonIOCapabilities)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\Jeff Reback\pandas3.5\pandas\io\tests\test_common.py", line 46, in test_stringify_path_pathlib
    self.assertEqual(redundant_path, 'foo/bar')
AssertionError: 'foo\\bar' != 'foo/bar'
- foo\bar
?    ^
+ foo/bar
?    ^


----------------------------------------------------------------------
Ran 8244 tests in 340.876s```
@flying-sheep

This comment has been minimized.

Show comment
Hide comment
@flying-sheep

flying-sheep Oct 18, 2015

Contributor

PR is #11362

Contributor

flying-sheep commented Oct 18, 2015

PR is #11362

Dr-Irv added a commit to Dr-Irv/pandas that referenced this issue Oct 24, 2015

Fix for issue #11317
This includes updates to 3 Excel files, plus a test in test_excel.py,
plus the fix in parsers.py

issue when read_html with previous fix

With read_html, the fix didn't work on Python 2.7.  Handle the string
conversion correctly

Add bug fixed to what's new

Revert "Add bug fixed to what's new"

This reverts commit 05b2344.

Revert "issue when read_html with previous fix"

This reverts commit d1bc296.

Add what's new to describe bug.  fix issue with original fix

Added text to describe the bug.
Fixed issue so that it works correctly in Python 2.7

Add round trip test

Added round trip test and fixed error in writing sheets when
merge_cells=false and columns have multi index

DEPR: deprecate pandas.io.ga, pandas-dev#11308

DEPR: deprecate engine keyword from to_csv pandas-dev#11274

remove warnings from the tests for deprecation of engine in to_csv

PERF: Checking monotonic-ness before sorting on an index pandas-dev#11080

BUG: Bug in list-like indexing with a mixed-integer Index, pandas-dev#11320

Add hex color strings test

CLN: GH11271 move _get_handle, UTF encoders to io.common

TST: tests for list skiprows in read_excel

BUG: Fix to_dict() problem when using only datetime pandas-dev#11247

Fix a bug where to_dict() does not return Timestamp when there is only
datetime dtype present.

Undo change for when columns are multiindex

There is still something wrong here in the format of the file when there
are multiindex columns, but that's for another day

Fix formatting in test_excel and remove spurious test

See title

BUG: bug in comparisons vs tuples, pandas-dev#11339

bug#10442 : fix, adding note and test

BUG pandas-dev#10442(test) : Convert datetimelike index to strings with astype(str)

BUG#10422: note added

bug#10442 : tests added

bug#10442 : note udated

BUG pandas-dev#10442(test) : Convert datetimelike index to strings with astype(str)

bug#10442: fix, adding note and test

bug#10442: fix, adding note and test

Adjust test so that merge_cells=False works correctly

Adjust the test so that if merge_cells=false, it does a proper
formatting of the columns in the single row header, and puts the row
header in the first row

Fix test for Python 2.7 and 3.5

The test is failing on Python 2.7 and 3.5, which appears to read in the
values as floats, and I cannot replicate.  So force the tests to pass by
just making the column names equal when merge_cells=False

Fix for openpyxl < 2, and for issue pandas-dev#11408

If using openpyxl < 2, and value is a string that could be a number,
force a string to be written out.  If using openpyxl >= 2.2, then fix
issue pandas-dev#11408 to do with merging cells

Use set_value_explicit instead of set_explicit_value

set_value_explicit is in openpyxl 1.6, changed in openpyxl 1.8, but
there is code in 1.8 to set set_value_explicit to set_explicit_value for
compatibility

Add line in whatsnew for issue 11408

ENH: added capability to handle Path/LocalPath objects, pandas-dev#11033

DOC: typo in whatsnew/0.17.1.txt

PERF: Release GIL on some datetime ops

BUG: Bug in DataFrame.replace with a datetime64[ns, tz] and a non-compat to_replace pandas-dev#11326

CLN: clean up internal impl of fillna/replace, xref pandas-dev#11153

PERF: fast inf checking in to_excel

PERF: Series.dropna with non-nan dtypes

fixed pathlib tests on windows

DEPR: remove some SparsePanel deprecation warnings in testing

DEPR: avoid numpy comparison to None warnings

API: indexing with a null key will raise a TypeError rather than a ValueError, pandas-dev#11356

WARN: elementwise comparisons with index names, xref pandas-dev#11162

DEPR warning in io/data.py w.r.t. order->sort_values

WARN: more elementwise comparisons to object

WARN: more uncomparables of numeric array vs object

BUG: quick fix for pandas-dev#10989

TST: add test case from Issue pandas-dev#10989

API: add _to_safe_for_reshape to allow safe insert/append with embedded CategoricalIndexes

Signed-off-by: Jeff Reback <jeff@reback.net>

BLD: conda

Revert "BLD: conda"

This reverts commit 0c8a8e1.

TST: remove invalid symbol warnings

TST: move some tests to slow

TST: fix some warnings filters

TST: import pandas_datareader, use for tests

TST: remove some deprecation warnings from imports

DEPR: fix VisibleDeprecationWarnings in sparse

TST: remove some warnings in test_nanops

ENH: Improve the error message in to_gbq when the DataFrame schema does not match pandas-dev#11359

add libgfortran to 1.8.1 build

binstar -> anaconda

remove link to issue 11328 in whatsnew

Fixes to document issue in code, small efficiency fix

Try to resolve rebase conflict in whats new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment