New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/COMPAT: python 3.5 compat #11097

Closed
jreback opened this Issue Sep 14, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@jreback
Contributor

jreback commented Sep 14, 2015

A few changes are needed: https://travis-ci.org/jreback/pandas/jobs/80331174 (since merged to master)

so the Call node as changed
need to do something like this: https://bitbucket.org/pytest-dev/pytest/pull-requests/296/astcall-signature-changed-on-35/diff

If this is fixed I think everything will pass. I guess this is an API change in python.

======================================================================
ERROR: test_df_use_case (pandas.computation.tests.test_eval.TestMathNumExprPandas)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/jreback/pandas/pandas/computation/tests/test_eval.py", line 1488, in test_df_use_case
    parser=self.parser)
  File "/home/travis/build/jreback/pandas/pandas/core/frame.py", line 2102, in eval
    return _eval(expr, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/eval.py", line 230, in eval
    truediv=truediv)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 656, in __init__
    self.terms = self.parse()
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 673, in parse
    return self._visitor.visit(self.expr)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 314, in visit
    return visitor(node, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 320, in visit_Module
    return self.visit(expr, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 314, in visit
    return visitor(node, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 498, in visit_Assign
    return self.visit(node.value, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 314, in visit
    return visitor(node, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 543, in visit_Call
    args = [self.visit(targ) for targ in node.args]
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 543, in <listcomp>
    args = [self.visit(targ) for targ in node.args]
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 314, in visit
    return visitor(node, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 545, in visit_Call
    if node.starargs is not None:
AttributeError: 'Call' object has no attribute 'starargs'

@jreback jreback modified the milestones: 0.17.1, 0.17.0 Sep 14, 2015

jreback added a commit to jreback/pandas that referenced this issue Sep 15, 2015

COMPAT: compat for python 3.5, pandas-dev#11097
- update install / compat docs for 3.5
- use visit_Call based on the version of python
- skip if html5lib is not installed in test_data
- bug in nose causes deprecation warning in some pytables tests
- remove superfluous socket timeout

jreback added a commit that referenced this issue Sep 15, 2015

Merge pull request #11114 from jreback/fix
COMPAT: compat for python 3.5, #11097

nickeubank added a commit to nickeubank/pandas that referenced this issue Sep 29, 2015

COMPAT: compat for python 3.5, pandas-dev#11097
- update install / compat docs for 3.5
- use visit_Call based on the version of python
- skip if html5lib is not installed in test_data
- bug in nose causes deprecation warning in some pytables tests
- remove superfluous socket timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment