New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use LocaleTime for date_field_name output #12806

Closed
BastiaanBergman opened this Issue Apr 5, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@BastiaanBergman

BastiaanBergman commented Apr 5, 2016

Instantiate LocaleTime and use the property .f_weekday to generate weekday and month names.

Currently datename strings are pulled from a hard coded (English) array in get_date_name_field() in tslib.py, better to pull these from a Locale adjusted array.

Code Sample:

pd.Timestamp("2016-04-06").weekday_name

Expected Output

e.g. for the a platform with Dutch locale:
'woensdag'

@jreback jreback added this to the 0.18.1 milestone Apr 6, 2016

@jreback jreback modified the milestones: 0.18.2, 0.18.1 Apr 25, 2016

@jorisvandenbossche jorisvandenbossche modified the milestones: Next Major Release, 0.19.0 Aug 18, 2016

@jreback jreback modified the milestones: Next Major Release, 0.22.0 Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment