Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Improve the performance of instantiating a Series object with dictionary data and a datetimeindex #14894
Comments
nateyoder
referenced
this issue
Dec 16, 2016
Closed
Clean up construction of Series with dictionary and datetime index #14895
sinhrks
added Performance Timeseries
labels
Dec 16, 2016
jreback
added this to the
0.19.2
milestone
Dec 16, 2016
jreback
closed this
in e503d40
Dec 17, 2016
ischurov
added a commit
to ischurov/pandas
that referenced
this issue
Dec 19, 2016
|
|
nateyoder + ischurov |
262be36
|
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this issue
Dec 24, 2016
|
|
nateyoder + jorisvandenbossche |
21ebc0f
|
ShaharBental
added a commit
to ShaharBental/pandas
that referenced
this issue
Dec 26, 2016
|
|
nateyoder + ShaharBental |
b36d0bf
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nateyoder commentedDec 16, 2016
The current code path always results in an exception on:
https://github.com/pandas-dev/pandas/blob/3ac41ab2d7ae446fa04f47ec911003cd722dbd65/pandas/core/series.py#L191
which is then caught. Only a slight performance advantage is seen but hopefully the code change makes it less confusing for newcomers like me.
Code Sample, a copy-pastable example if possible
Problem description
The current code path always results in an exception on:
https://github.com/pandas-dev/pandas/blob/3ac41ab2d7ae446fa04f47ec911003cd722dbd65/pandas/core/series.py#L191
which is then caught. Only a slight performance advantage is seen but hopefully the code change makes it less confusing for newcomers like me.
ASV output of new benchmark
Running 2 total benchmarks (2 commits * 1 environments * 1 benchmarks)
[ 0.00%] · For pandas commit hash 5f05fdc:
[ 0.00%] ·· Building for conda-py2.7-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt.................................
[ 0.00%] ·· Benchmarking conda-py2.7-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 50.00%] ··· Running ...x.time_series_constructor_no_data_datetime_index 3.26s
[ 50.00%] · For pandas commit hash 3ba2cff:
[ 50.00%] ·· Building for conda-py2.7-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt...
[ 50.00%] ·· Benchmarking conda-py2.7-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[100.00%] ··· Running ...x.time_series_constructor_no_data_datetime_index 3.77s before after ratio
[3ba2cff] [5f05fdc]