Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
DatetimeIndex._maybe_cast_slice_bound with duplicates #16515
Comments
TomAugspurger
added Algos Difficulty Intermediate Effort Low Indexing Timeseries
labels
May 26, 2017
TomAugspurger
added this to the
Next Major Release
milestone
May 26, 2017
|
Actually, we don't need any additional cython code. We can just do @property
def is_strictly_monotonically_increasing(self):
return self.is_unique and self.is_monotonic_increasingDo we want to add that as a method? I'm slightly in favor of adding it. |
|
@TomAugspurger yeah that sound fine (add tests as well), do this in base and it should just work for all Index sub-classes (maybe add is_strictly_monotonicaly_decreasing as well) |
TomAugspurger
added Difficulty Novice and removed Difficulty Intermediate
labels
May 31, 2017
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this issue
May 31, 2017
|
|
TomAugspurger |
5fc8831
|
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this issue
May 31, 2017
|
|
TomAugspurger |
e8054d5
|
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this issue
May 31, 2017
|
|
TomAugspurger |
6e2eb0e
|
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this issue
May 31, 2017
|
|
TomAugspurger |
dcd38f0
|
jreback
closed this
in #16555
Jun 1, 2017
jreback
modified the milestone: 0.20.2, Next Major Release
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TomAugspurger commentedMay 26, 2017
DatetimeIndex._maybe_cast_slice_boundcan return the wrong value when you have an index that is monotonically decreasing, but not strictly monotonically decreasing.The issue is here That check really needs to check for strict monotonic decreasing, not just monotonic decreasing.
Have we hit any other needs for strict monotonic algos? This is such an extreme edge case, not sure it's worthwhile on its own.
Came up in dask/dask#2389