New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda recipe for new conda #18002

Closed
TomAugspurger opened this Issue Oct 27, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@TomAugspurger
Contributor

TomAugspurger commented Oct 27, 2017

conda build ./conda.recipe/ --numpy 1.11 --python 3.6 -q --output

Recipe at /Users/taugspurger/Envs/pandas-dev/lib/python3.6/site-packages/pandas/conda.recipe uses numpy x.x.  This is deprecated as of conda-build 3.0, and will be removed in conda-build 4.0.  Please consider using variants with pin_run_as_build instead.  More info at https://conda.io/docs/building/variants.html#customizing-compatibility
WARNING:conda_build.metadata:Recipe at /Users/taugspurger/Envs/pandas-dev/lib/python3.6/site-packages/pandas/conda.recipe uses numpy x.x.  This is deprecated as of conda-build 3.0, and will be removed in conda-build 4.0.  Please consider using variants with pin_run_as_build instead.  More info at https://conda.io/docs/building/variants.html#customizing-compatibility
/Users/taugspurger/miniconda3/conda-bld/osx-64/pandas-0.21.0rc1-np111py36_43_ge38bd749d.tar.bz2

@TomAugspurger TomAugspurger added this to the Next Major Release milestone Oct 27, 2017

@bobhaffner

This comment has been minimized.

Contributor

bobhaffner commented Dec 1, 2017

Is anyone looking at this? If not, I can submit a PR.

My proposed changes. It doesn't throw a warning and it builds and installs

@@ -14,14 +14,14 @@ requirements:
   build:
     - python
     - cython
-    - numpy
+    - numpy x.x
     - setuptools
     - pytz
     - python-dateutil
 
   run:
     - python
-    - {{ pin_compatible('numpy') }}
+    - numpy x.x
     - python-dateutil
     - pytz
 
@TomAugspurger

This comment has been minimized.

Contributor

TomAugspurger commented Dec 1, 2017

Seems reasonable to me.

@bobhaffner

This comment has been minimized.

Contributor

bobhaffner commented Dec 1, 2017

Good deal, I'll submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment