New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: since we already use setuptools, let's remove the optional logic in setup.py #18113

Closed
jreback opened this Issue Nov 4, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@jreback
Contributor

jreback commented Nov 4, 2017

no need to have the branching in setup.py we always have setuptools available.

@kchomski-reef

This comment has been minimized.

Contributor

kchomski-reef commented Nov 6, 2017

Besides cleaning up setup.py does something else should be done? Are there any caveats regarding pandas build process?

@jreback

This comment has been minimized.

Contributor

jreback commented Nov 6, 2017

no i think this all that is needed; we do sufficient testing on building in the CI

@kchomski-reef

This comment has been minimized.

Contributor

kchomski-reef commented Nov 7, 2017

@jreback Do you think we could have Build subsection in whatsnew docs for BLD related entries? Or do they fall under one of existing subsections?

@jbrockmendel

This comment has been minimized.

Member

jbrockmendel commented Nov 17, 2017

the try/except of import setuptools also includes import pkg_resources. Is it also always the case that we always have pkg_resources?

@jbrockmendel jbrockmendel referenced this issue Nov 17, 2017

Closed

remove have_setuptools branching #18349

2 of 4 tasks complete

jreback added a commit to jreback/pandas that referenced this issue Dec 3, 2017

BLD: since we already use setuptools, let's remove the optional logic…
closes pandas-dev#18113

Author: Grzegorz Konefał <grzegorz.konefal@reef.pl>
Author: Krzysztof Chomski <krzysztof.chomski@reef.pl>

Closes pandas-dev#18448 from gkonefal-reef/GH18113 and squashes the following commits:

21cbe79 [Grzegorz Konefał] Comments applied
290b49c [Krzysztof Chomski] BLD: since we already use setuptools, let's remove the optional logic in setup.py (GH18113).

jreback added a commit to jreback/pandas that referenced this issue Dec 3, 2017

BLD: since we already use setuptools, let's remove the optional logic…
closes pandas-dev#18113

Author: Grzegorz Konefał <grzegorz.konefal@reef.pl>
Author: Krzysztof Chomski <krzysztof.chomski@reef.pl>

Closes pandas-dev#18448 from gkonefal-reef/GH18113 and squashes the following commits:

21cbe79 [Grzegorz Konefał] Comments applied
290b49c [Krzysztof Chomski] BLD: since we already use setuptools, let's remove the optional logic in setup.py (GH18113).

@jreback jreback closed this in a9e4731 Dec 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment