Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Deprecate Index.summary #18217
Apologies if any of this is super naive. I'm new.
Deleting the method and any tests directly targeting it isn't enough. There are other failures like
The reason is the output of
(That second element is the output from
Would it be more appropriate to
An alternative is to update the tests to make them pass, but I don't know if that's a good idea.
def summary(self): warnings.warn("Index.summary is deprecated and will be removed in a future version") return self._summary()
Thanks for the feedback. Works for me. I'll get to this soon.…
On Wed, Nov 29, 2017 at 6:31 PM, Tom Augspurger ***@***.***> wrote: I would 1. Rename Index.summary to Index._summary 2. Change anywhere in pandas where we currently use Index.summary to Index._summary 3. Make a new Index.summary that looks like def summary(self): warnings.warn("Index.summary is deprecated and will be removed in a future version") return self._summary() — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18217 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGJ2sN9r904XWOs12ZZwRFsFJSPhFqi1ks5s7hNsgaJpZM4QZwWi> .