Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
CLN: Remove days, seconds and microseconds properties from timedelta.pyx #18242
The days, seconds and microseconds properties defined in timedelta.pyx could potentially be removed as they are defined in the Cython superclass. See Jeff's comments in the linked PR for caveats that need to be explored before totally committing to this.
Nov 12, 2017
Here's what I got from ASV after removing those properties. Note that there is no nanoseconds property in CPython's source, so that will need to remain here for the time being
From a few runs it looks like me like savings could be 20-25%. You've called out before that this will make our docstrings inconsistent and it is a little clunky since nanoseconds would still be around. On the flip side, it is less code for pandas and gives a slight performance boost. Worth a PR?