New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

len-1 scalar is accepted as valid input for len >1 Series #18819

Closed
toobaz opened this Issue Dec 18, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@toobaz
Member

toobaz commented Dec 18, 2017

Code Sample, a copy-pastable example if possible

In [2]: pd.Series([1], [0,1])
Out[2]: 
0    1
1    1
dtype: int64

Problem description

This is undocumented, conceptually wrong, works only because of an implementation glitch, and is used in 3 tests only - I think - by mistake.

Already discussed (and potentially fixed) inside #18626 (where @jorisvandenbossche suggested a proper deprecation cycle), but @jreback suggested to open a specific issue.

Expected Output

ValueError: Wrong number of items passed 1, placement implies 2

Output of pd.show_versions()

INSTALLED VERSIONS

commit: b5f1e71
python: 3.5.3.final.0
python-bits: 64
OS: Linux
OS-release: 4.9.0-4-amd64
machine: x86_64
processor:
byteorder: little
LC_ALL: None
LANG: it_IT.UTF-8
LOCALE: it_IT.UTF-8

pandas: 0.22.0.dev0+371.gb5f1e716d
pytest: 3.2.3
pip: 9.0.1
setuptools: 36.7.0
Cython: 0.25.2
numpy: 1.12.1
scipy: 0.19.0
pyarrow: None
xarray: None
IPython: 6.2.1
sphinx: 1.5.6
patsy: 0.4.1
dateutil: 2.6.1
pytz: 2017.2
blosc: None
bottleneck: 1.2.0dev
tables: 3.3.0
numexpr: 2.6.1
feather: 0.3.1
matplotlib: 2.0.0
openpyxl: 2.3.0
xlrd: 1.0.0
xlwt: 1.3.0
xlsxwriter: 0.9.6
lxml: 4.1.1
bs4: 4.5.3
html5lib: 0.999999999
sqlalchemy: 1.0.15
pymysql: None
psycopg2: None
jinja2: 2.10
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: 0.2.1

@toobaz toobaz referenced this issue Dec 18, 2017

Merged

Construct 1d array from listlike #18769

2 of 2 tasks complete

@jreback jreback added this to the Next Major Release milestone Dec 18, 2017

@jreback

This comment has been minimized.

Contributor

jreback commented Dec 18, 2017

yep, this should raise

@jorisvandenbossche

This comment has been minimized.

Member

jorisvandenbossche commented Apr 26, 2018

@toobaz I think you fixed this in one of your PRs?

@toobaz

This comment has been minimized.

Member

toobaz commented Apr 27, 2018

@jorisvandenbossche true, I was supposed to do so in #18626 , but it was not merged, and a git bisect shows that @cbertinato fixed this instead in #19714, also adding a test (but apparently not a whatsnew)

toobaz added a commit to toobaz/pandas that referenced this issue May 1, 2018

@toobaz toobaz referenced this issue May 1, 2018

Merged

DOC: whatsnew for GH #18819 #20901

3 of 3 tasks complete

TomAugspurger added a commit that referenced this issue May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment