Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int64Index.get_loc() is very slow on unsorted, non-unique index #19478

Closed
toobaz opened this Issue Jan 31, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@toobaz
Copy link
Member

commented Jan 31, 2018

Code Sample, a copy-pastable example if possible

In [2]: idx = pd.Int64Index(np.random.randint(2000, size=10000))

In [3]: %timeit idx.get_loc(1000)
316 µs ± 1.73 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

In [4]: %timeit np.where((idx == 1000))
26.6 µs ± 268 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [5]: (idx.get_loc(1000) == (idx == 1000)).all()
Out[5]: True

Problem description

In [4]: does the same thing that In [3]: does, taking ~11 times less.

Might be related to #9466 .

Output of pd.show_versions()

INSTALLED VERSIONS

commit: None
python: 3.5.3.final.0
python-bits: 64
OS: Linux
OS-release: 4.9.0-5-amd64
machine: x86_64
processor:
byteorder: little
LC_ALL: None
LANG: it_IT.UTF-8
LOCALE: it_IT.UTF-8

pandas: 0.23.0.dev0+187.g4618a0918.dirty
pytest: 3.2.3
pip: 9.0.1
setuptools: 36.7.0
Cython: 0.25.2
numpy: 1.12.1
scipy: 0.19.0
pyarrow: None
xarray: None
IPython: 6.2.1
sphinx: 1.5.6
patsy: 0.4.1
dateutil: 2.6.1
pytz: 2017.2
blosc: None
bottleneck: 1.2.0dev
tables: 3.3.0
numexpr: 2.6.1
feather: 0.3.1
matplotlib: 2.0.0
openpyxl: 2.3.0
xlrd: 1.0.0
xlwt: 1.3.0
xlsxwriter: 0.9.6
lxml: 4.1.1
bs4: 4.5.3
html5lib: 0.999999999
sqlalchemy: 1.0.15
pymysql: None
psycopg2: None
jinja2: 2.10
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: 0.2.1

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2018

maybe a manifestation of #17754

@jreback jreback added this to the Next Major Release milestone Feb 1, 2018

toobaz added a commit to toobaz/pandas that referenced this issue Feb 5, 2018

toobaz added a commit to toobaz/pandas that referenced this issue Feb 5, 2018

toobaz added a commit to toobaz/pandas that referenced this issue Feb 5, 2018

toobaz added a commit to toobaz/pandas that referenced this issue Feb 5, 2018

toobaz added a commit to toobaz/pandas that referenced this issue Feb 5, 2018

@jreback jreback modified the milestones: Next Major Release, 0.23.0 Feb 6, 2018

toobaz added a commit to toobaz/pandas that referenced this issue Apr 2, 2018

@jreback jreback modified the milestones: 0.23.0, Next Major Release Apr 14, 2018

toobaz added a commit to toobaz/pandas that referenced this issue May 5, 2018

@jreback jreback modified the milestones: Next Major Release, 0.23.0 May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.