New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)-deprecate order keyword in factorize #19727

Closed
TomAugspurger opened this Issue Feb 16, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@TomAugspurger
Contributor

TomAugspurger commented Feb 16, 2018

In #6930 we deprecated order.

As of 0.18.1, the keyword was no-longer documented, and doesn't raise, but wasn't actually removed.

In [3]: pandas.factorize([0, 1], order=True)
Out[3]: (array([0, 1]), array([0, 1]))

In [4]: pandas.__version__
Out[4]: '0.18.1'

@TomAugspurger TomAugspurger changed the title from (Re)-deprecate order keyword in to (Re)-deprecate order keyword in factorize Feb 16, 2018

@TomAugspurger TomAugspurger added this to the Next Major Release milestone Feb 16, 2018

@TomAugspurger

This comment has been minimized.

Contributor

TomAugspurger commented Feb 16, 2018

I don't have a strong preference on deprecating vs. just removing. Probably best to deprecate for one release.

@jorisvandenbossche

This comment has been minimized.

Member

jorisvandenbossche commented Feb 16, 2018

To be clear, it seems the order keyword does nothing (so it was forgotten to be removed from the signature).

@EricChea

This comment has been minimized.

Contributor

EricChea commented Feb 18, 2018

I can take this. I'm made some mods to deprecate_kwargs in pandas/util/_decorators.py to accommodate and just need to write some tests.

@jreback jreback modified the milestones: Next Major Release, 0.23.0 Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment