Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS/DEPR: Allow import of feather through pyarrow #21639

Closed
h-vetinari opened this issue Jun 26, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@h-vetinari
Copy link
Contributor

commented Jun 26, 2018

Currently, DataFrame.to_feather() tries to import feather, which only works if feather-format is installed. The same capabilities could also be imported as follows: import pyarrow.feather as feather.

The issue is that pyarrow is more easily available (e.g. conda install feather-format doesn't work without specifying a specific channel; but pyarrow works), and is under more active development.

I asked if there is a preference between the two imports in wesm/feather#341, and Wes answered [my bold]:

You can use either method; there is no explicit recommendation right now. import feather is provided for backwards compatibility

I think the import should at least try import pyarrow.feather as feather as well, if import feather fails.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

would take a PR to use pyarrow.feather
i suppose should continue to accept feather-format but deprecate it as a dep

@h-vetinari h-vetinari changed the title Allow import of feather through pyarrows DEPS/DEPR: Allow import of feather through pyarrow Jun 26, 2018

@gfyoung gfyoung added the Deprecate label Jun 27, 2018

@jreback jreback added this to the 0.24.0 milestone Oct 18, 2018

ingwinlu added a commit to ingwinlu/pandas that referenced this issue Oct 29, 2018

BUG: Deprecate nthreads argument
The nthreads argument is no longer supported since pyarrow 0.11.0 and
was replaced with use_threads.
Hence we deprecate the argument now as well so we can remove it in the
future.

This commit also:
- removes feather-format as a dependency and replaces it with usage of
  pyarrow directly.
- sets CI dependencies to respect the changes above.

We test backwards compatibility with pyarrow 0.9.0 as conda does not
provide a pyarrow 0.10.0 and the conda-forge version has comatibility
issues with the rest of the installed packages.

Resolves pandas-dev#23053.
Resolves pandas-dev#21639.

ingwinlu added a commit to ingwinlu/pandas that referenced this issue Nov 1, 2018

BUG: Deprecate nthreads argument
The nthreads argument is no longer supported since pyarrow 0.11.0 and
was replaced with use_threads.
Hence we deprecate the argument now as well so we can remove it in the
future.

This commit also:
- removes feather-format as a dependency and replaces it with usage of
  pyarrow directly.
- sets CI dependencies to respect the changes above.

We test backwards compatibility with pyarrow 0.9.0 as conda does not
provide a pyarrow 0.10.0 and the conda-forge version has comatibility
issues with the rest of the installed packages.

Resolves pandas-dev#23053.
Resolves pandas-dev#21639.

ingwinlu added a commit to ingwinlu/pandas that referenced this issue Nov 1, 2018

BUG: Deprecate nthreads argument
The nthreads argument is no longer supported since pyarrow 0.11.0 and
was replaced with use_threads.
Hence we deprecate the argument now as well so we can remove it in the
future.

This commit also:
- removes feather-format as a dependency and replaces it with usage of
  pyarrow directly.
- sets CI dependencies to respect the changes above.

We test backwards compatibility with pyarrow 0.9.0 as conda does not
provide a pyarrow 0.10.0 and the conda-forge version has comatibility
issues with the rest of the installed packages.

Resolves pandas-dev#23053.
Resolves pandas-dev#21639.

brute4s99 added a commit to brute4s99/pandas that referenced this issue Nov 19, 2018

BUG: Deprecate nthreads argument (pandas-dev#23112)
The nthreads argument is no longer supported since pyarrow 0.11.0 and
was replaced with use_threads.
Hence we deprecate the argument now as well so we can remove it in the
future.

This commit also:
- removes feather-format as a dependency and replaces it with usage of
  pyarrow directly.
- sets CI dependencies to respect the changes above.

We test backwards compatibility with pyarrow 0.9.0 as conda does not
provide a pyarrow 0.10.0 and the conda-forge version has comatibility
issues with the rest of the installed packages.

Resolves pandas-dev#23053.
Resolves pandas-dev#21639.

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this issue Feb 28, 2019

BUG: Deprecate nthreads argument (pandas-dev#23112)
The nthreads argument is no longer supported since pyarrow 0.11.0 and
was replaced with use_threads.
Hence we deprecate the argument now as well so we can remove it in the
future.

This commit also:
- removes feather-format as a dependency and replaces it with usage of
  pyarrow directly.
- sets CI dependencies to respect the changes above.

We test backwards compatibility with pyarrow 0.9.0 as conda does not
provide a pyarrow 0.10.0 and the conda-forge version has comatibility
issues with the rest of the installed packages.

Resolves pandas-dev#23053.
Resolves pandas-dev#21639.

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this issue Feb 28, 2019

BUG: Deprecate nthreads argument (pandas-dev#23112)
The nthreads argument is no longer supported since pyarrow 0.11.0 and
was replaced with use_threads.
Hence we deprecate the argument now as well so we can remove it in the
future.

This commit also:
- removes feather-format as a dependency and replaces it with usage of
  pyarrow directly.
- sets CI dependencies to respect the changes above.

We test backwards compatibility with pyarrow 0.9.0 as conda does not
provide a pyarrow 0.10.0 and the conda-forge version has comatibility
issues with the rest of the installed packages.

Resolves pandas-dev#23053.
Resolves pandas-dev#21639.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.